feat(workspace): add lifecycle controller - #53
Merged
Conversation
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #52
status:approvedlabel.Pull request type
Select exactly one option and apply the matching
type:*label.type:bug)type:feature)type:docs)type:refactor)type:chore)type:breaking-change)Summary
code/message/platform/retryableerror contracts.size:exceptionfor 1,062 additions across exactly four files; PR11a is a focused split from task 4.2, with Tauri/UI wiring deferred to task 4.2b.Changes
crates/splice-core/src/workspace_lifecycle.rscrates/splice-core/tests/workspace_lifecycle.rscrates/splice-core/src/workspace.rscrates/splice-core/src/lib.rsTest plan
cargo test -p splice-core --test workspace_lifecycle(16 passed; 0 failed).cargo test -p splice-core(30 passed; 0 failed, including 16 lifecycle, 9 store, and 5 unit tests).cargo fmt --all -- --checkandcargo clippy -p splice-core --all-targets -- -D warnings(passed).cargo test -p splice-core --target x86_64-pc-windows-gnu --no-run(passed).UnsupportedPlatform; this PR does not touch Tauri or UI code.Chained pull request context
masterReview budget: 1,062 additions / 0 deletions across four files. The accepted
size:exceptionkeeps implementation and exhaustive failure-semantics tests in one rollback-safe work unit; splitting tests from behavior would reduce review integrity.Rollback boundary: revert commit
4c3b487. This removes the lifecycle module/tests and reverts only its exports plus lifecycle persistence/listing fields; no Tauri/UI behavior or unrelated workspace persistence is removed.Contributor checklist
Closes,Fixes, orResolves.type:*label.Co-Authored-Bytrailers.