feat(platform): enforce Tauri command authority - #43
Merged
Conversation
22 tasks
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #41
status:approvedlabel.Pull request type
Select exactly one option and apply the matching
type:*label.type:bug)type:feature)type:docs)type:refactor)type:chore)type:breaking-change)Summary
pty_spawnauthority remains deferred to task 3.2.Supersedes #42.
Changes
apps/desktop/src-tauri/build.rsapps/desktop/src-tauri/capabilities/{linux,windows}.jsonpty_spawn.apps/desktop/src-tauri/permissions/terminal.tomlapps/desktop/src-tauri/permissions/autogenerated/*.tomlapps/desktop/src-tauri/tests/authority_manifest.rsReview budget: 288 authored changed lines plus 154 generated changed lines across 19 paths. Generated contracts are complete and excluded from the authored 400-line budget.
Test plan
cargo test -p splice-shell-desktop --test authority_manifest && cargo test -p splice-shell-desktop --test platform_authority && cargo test -p splice-shell-desktop --lib open_path_rejects_missing_paths(5/5 passed).cargo fmt --all --checkandgit diff --checkpassed.Warnings: strict native Linux Clippy remains baseline-blocked by two unchanged
splice-clipboarddead-code diagnostics. Scoped native Clippy and Windows GNU Clippy pass. Packaged unauthorized-invoke denial is not claimed. Linuxpty_spawncapability authority is intentionally deferred to task 3.2.Chained pull request context
pty_spawnauthority, packaged-runtime unauthorized invocation denial, task 3.2, frontend integration, packaging, and all later workmasterat merged PR #40pty_spawnauthorityorigin/master0ac54b8with PR5a mergedChain overview
Scope
pty_spawncapability authority, packaged-runtime denial evidence, task 3.2, and all later work.Autonomy
Rollback: revert commit
85ecd1c; this removes only the 19 authority-manifest paths/changes and preserves merged PR5a platform services.Contributor checklist
Closes,Fixes, orResolves.type:*label.Co-Authored-Bytrailers.