Skip to content

fix(commerce-onboarding): truncate companion item labels#4312

Open
tlgimenes wants to merge 1 commit into
mainfrom
theta-normae
Open

fix(commerce-onboarding): truncate companion item labels#4312
tlgimenes wants to merge 1 commit into
mainfrom
theta-normae

Conversation

@tlgimenes

@tlgimenes tlgimenes commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Constrain companion MCP selectable rows so long GA property and GSC site labels truncate inside the dialog.
  • Add component coverage for long selectable labels.

Test Plan

  • bun test apps/mesh/src/web/routes/commerce-onboarding

Summary by cubic

Truncates long GA property and GSC site labels in the Commerce onboarding companion list so the dialog doesn’t stretch.

  • Bug Fixes
    • Constrain row button with min-w-0 to enable truncation.
    • Set label span to min-w-0 flex-1 truncate to keep text inside the row.
    • Add a unit test for long labels in SelectableList.

Written for commit 7f6402c. Summary will update on new commits.

Review in cubic

@tlgimenes tlgimenes enabled auto-merge (squash) July 3, 2026 17:54

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/mesh/src/web/routes/commerce-onboarding/companion-forms/selectable-list.test.tsx">

<violation number="1" location="apps/mesh/src/web/routes/commerce-onboarding/companion-forms/selectable-list.test.tsx:6">
P3: Redundant `import "@testing-library/jest-dom"` — the setup file already registers jest-dom matchers via `expect.extend(matchers)` for bun:test, and the type augmentation is already declared in the setup. The side-effect import does nothing in a bun environment and should be removed to avoid misleading future readers.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic


import { describe, expect, it } from "bun:test";
import { render } from "@testing-library/react";
import "@testing-library/jest-dom";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Redundant import "@testing-library/jest-dom" — the setup file already registers jest-dom matchers via expect.extend(matchers) for bun:test, and the type augmentation is already declared in the setup. The side-effect import does nothing in a bun environment and should be removed to avoid misleading future readers.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mesh/src/web/routes/commerce-onboarding/companion-forms/selectable-list.test.tsx, line 6:

<comment>Redundant `import "@testing-library/jest-dom"` — the setup file already registers jest-dom matchers via `expect.extend(matchers)` for bun:test, and the type augmentation is already declared in the setup. The side-effect import does nothing in a bun environment and should be removed to avoid misleading future readers.</comment>

<file context>
@@ -0,0 +1,26 @@
+
+import { describe, expect, it } from "bun:test";
+import { render } from "@testing-library/react";
+import "@testing-library/jest-dom";
+import { SelectableList } from "./selectable-list.tsx";
+
</file context>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant