fix(commerce-onboarding): truncate companion item labels#4312
Open
tlgimenes wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/mesh/src/web/routes/commerce-onboarding/companion-forms/selectable-list.test.tsx">
<violation number="1" location="apps/mesh/src/web/routes/commerce-onboarding/companion-forms/selectable-list.test.tsx:6">
P3: Redundant `import "@testing-library/jest-dom"` — the setup file already registers jest-dom matchers via `expect.extend(matchers)` for bun:test, and the type augmentation is already declared in the setup. The side-effect import does nothing in a bun environment and should be removed to avoid misleading future readers.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
|
||
| import { describe, expect, it } from "bun:test"; | ||
| import { render } from "@testing-library/react"; | ||
| import "@testing-library/jest-dom"; |
Contributor
There was a problem hiding this comment.
P3: Redundant import "@testing-library/jest-dom" — the setup file already registers jest-dom matchers via expect.extend(matchers) for bun:test, and the type augmentation is already declared in the setup. The side-effect import does nothing in a bun environment and should be removed to avoid misleading future readers.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mesh/src/web/routes/commerce-onboarding/companion-forms/selectable-list.test.tsx, line 6:
<comment>Redundant `import "@testing-library/jest-dom"` — the setup file already registers jest-dom matchers via `expect.extend(matchers)` for bun:test, and the type augmentation is already declared in the setup. The side-effect import does nothing in a bun environment and should be removed to avoid misleading future readers.</comment>
<file context>
@@ -0,0 +1,26 @@
+
+import { describe, expect, it } from "bun:test";
+import { render } from "@testing-library/react";
+import "@testing-library/jest-dom";
+import { SelectableList } from "./selectable-list.tsx";
+
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Summary by cubic
Truncates long GA property and GSC site labels in the Commerce onboarding companion list so the dialog doesn’t stretch.
SelectableList.Written for commit 7f6402c. Summary will update on new commits.