fix(performance): simplify sprites-report prerequisites#6
Open
igoramf wants to merge 6 commits into
Open
Conversation
…oudflare-specific html cache skills Replace hardcoded ClickHouse credentials in sprites-report with a plain note to connect to the deco Stats Lake. Remove html-cache-report-cloudflare and html-cache-weekly-report-cloudflare skills (superseded by the unified html-cache-report). Clean up design spec doc.
Contributor
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="agents/performance/agent.md">
<violation number="1" location="agents/performance/agent.md:34">
P2: This reintroduces `html-cache-report-cloudflare` even though the PR says it was superseded by `html-cache-report`; remove it to keep the skill list consistent with the intended consolidation.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| Use this skill to analyze CDN traffic for `/sprites.svg` using ClickHouse Stats Lake. Reports which sites consume the most requests and bandwidth via sprites, and details cache performance per site. | ||
|
|
||
| - **html-cache-report-cloudflare.md** | ||
| Use this skill to generate an HTML cache report scoped exclusively to Cloudflare CDN sites. Uses GraphQL to discover which sites are on Cloudflare, ClickHouse for CDN cache metrics, and HyperDX to correlate loader cache blockers. |
Contributor
There was a problem hiding this comment.
P2: This reintroduces html-cache-report-cloudflare even though the PR says it was superseded by html-cache-report; remove it to keep the skill list consistent with the intended consolidation.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At agents/performance/agent.md, line 34:
<comment>This reintroduces `html-cache-report-cloudflare` even though the PR says it was superseded by `html-cache-report`; remove it to keep the skill list consistent with the intended consolidation.</comment>
<file context>
@@ -17,4 +17,18 @@ Use this skill to improve how images are being used in the website, you will che
+Use this skill to analyze CDN traffic for `/sprites.svg` using ClickHouse Stats Lake. Reports which sites consume the most requests and bandwidth via sprites, and details cache performance per site.
+
+- **html-cache-report-cloudflare.md**
+Use this skill to generate an HTML cache report scoped exclusively to Cloudflare CDN sites. Uses GraphQL to discover which sites are on Cloudflare, ClickHouse for CDN cache metrics, and HyperDX to correlate loader cache blockers.
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sprites-reportprerequisites with a plain note to connect to the deco Stats Lakehtml-cache-report-cloudflareandhtml-cache-weekly-report-cloudflareskills (superseded by the unifiedhtml-cache-report)Test plan
sprites-reportskill loads correctly and prerequisites section is clearSummary by cubic
Adds new performance skills for HTML cache investigation, unified HTML cache reporting, loader cache reporting, and sprites reporting, and links them in the performance agent. Simplifies
sprites-reportprerequisites by removing hardcoded ClickHouse credentials and removes Cloudflare-only HTML cache report skills.New Features
html-cache-investigation— find the first reason specific HTML pages don’t cache (headers, Set-Cookie, runtime/cache gates).html-cache-report— unified CDN HTML cache report using ClickHouse Stats Lake.loader-cache-report— analyze loader cache (hit/miss/stale, latency) via HyperDX and audit loader configs.sprites-report— analyze/sprites.svgtraffic and cache performance across sites.Refactors
sprites-reportwith a simple note to connect to the deco Stats Lake.html-cache-report-cloudflareandhtml-cache-weekly-report-cloudflare(superseded byhtml-cache-report).README.mdandagents/performance/agent.mdto include the new skills.Written for commit cf486a9. Summary will update on new commits.