Skip to content

fix(vtex): check for :slug prefix instead of just : in PDP loaders#1638

Merged
guitavano merged 1 commit into
mainfrom
fix/pdp-check-slug-prefix
Jul 9, 2026
Merged

fix(vtex): check for :slug prefix instead of just : in PDP loaders#1638
guitavano merged 1 commit into
mainfrom
fix/pdp-check-slug-prefix

Conversation

@guitavano

@guitavano guitavano commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix slug prefix check from startsWith(":") to startsWith(":slug") in both intelligent search and legacy PDP loaders
  • The previous check was too broad, matching any string starting with : instead of the specific :slug placeholder

Test plan

  • Verify PDP pages load correctly with valid slugs
  • Verify fallback to PDPDefaultPath triggers only when slug is the :slug placeholder

🤖 Generated with Claude Code


Summary by cubic

Fix PDP slug placeholder detection by checking for ':slug' instead of any ':' in both intelligent search and legacy loaders. Prevents unnecessary fallback to PDPDefaultPath for valid slugs so PDP pages resolve correctly.

Written for commit c666565. Summary will update on new commits.

Review in cubic

The slug check was too broad, matching any string starting with ":"
instead of specifically checking for the ":slug" placeholder.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@guitavano, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1b56e757-541f-44e0-82fe-0de8856f0ab1

📥 Commits

Reviewing files that changed from the base of the PR and between b562530 and c666565.

📒 Files selected for processing (2)
  • vtex/loaders/intelligentSearch/productDetailsPage.ts
  • vtex/loaders/legacy/productDetailsPage.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pdp-check-slug-prefix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.159.2 update
  • 🎉 for Minor 0.160.0 update
  • 🚀 for Major 1.0.0 update

@guitavano guitavano merged commit 9ddd5c8 into main Jul 9, 2026
7 checks passed
@guitavano guitavano deleted the fix/pdp-check-slug-prefix branch July 9, 2026 19:20

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant