Convert to Python3 - #5
Open
ralic wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for the PR, have you tested this with the multimeter? Also, you seem to have accidentally commited |
ddworken
reviewed
May 20, 2017
| grapher = grapher([0]) | ||
| if args.csv: | ||
| print args.port[0] + ',' | ||
| print((args.port[0] + ',')) |
Owner
There was a problem hiding this comment.
All of the lines like this are technically correct changes, but have an unnecessary set of parentheses because print("first"+"second") works correctly.
Author
|
Just updated the pull request again... Thanks ! |
Owner
|
Changes look good to me, have you tested this to check that it all functions properly with the multimeter? |
sindrinj
approved these changes
Aug 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using : find . -name '*.py' | xargs 2to3 -w