chore: scope Dependabot to skip Vaadin-managed npm packages#10
Merged
Conversation
The vaadin-maven-plugin regenerates package.json on every build and pins the frontend npm toolchain (vite, @vitejs/*, esbuild, @vaadin/*, react-router, react, react-dom, lit) to versions tested against <vaadin.version> in pom.xml. Dependabot bumps to those packages are reverted by the build and never take effect, so ignore them here. Upgrade them by bumping <vaadin.version> instead. Maven updates stay on. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is a Vaadin Hilla project. The
vaadin-maven-plugin(flow:prepare-frontend) regeneratespackage.jsonon every build and pins the frontend npm toolchain to the versions that ship with the configured<vaadin.version>(25.1.6) inpom.xml.Verified empirically: building the open Dependabot PR #8 branch with
./mvnw -Pproduction clean packagerevertedreact-router7.16.0 → 7.13.1 inpackage.json. So Dependabot bumps to Vaadin-managed packages never take effect — they just create no-op PRs and a dirty tree.What
Add
.github/dependabot.ymlthat:vite,@vitejs/*,esbuild,@vaadin/*,react-router,react,react-dom,lit).Upgrade the ignored frontend packages by bumping
<vaadin.version>inpom.xmlinstead.Companion cleanup: open Dependabot PRs #8 and #9 are being closed (
@dependabot ignore) as they target these managed packages.🤖 Generated with Claude Code