Repository navigation
Fix Erraneous Cases in Migration Skill - #157
Merged
Merged
Conversation
Contributor
|
Is it ready for review? If so, we'll need to bump the versions. |
Contributor
|
Hey @b-per. I have a couple more things I want to push on the next release. I'll push them to this branch so that we can get them all in together. |
b-per
marked this pull request as draft
September 2, 2026 16:22
Contributor
|
Thanks @sriramr98 |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ash2shukla
marked this pull request as ready for review
September 3, 2026 07:06
The exit gate used to trigger the customer's own dbt platform jobs, which run on the deployment environment's credentials and target schema - very often production. Verification now stays in the develop session, on the signed-in user's own development credentials. On dbt platform the gate is a fixed set of commands run in order, stopping at the first failure: dbt parse, compile, build, test. In VS Code it is dbt parse alone, because that profile parses against a synthesized profile with fake credentials, so anything that connects fails at connection rather than informatively. migration_jobs.json is decoupled from the gate. It is no longer the source of the commands to run - it records which job commands the customer must change after merging. The agent builds it by listing the project's jobs and keeping the ones on a legacy version, rather than being handed job IDs.
Contributor
|
Hi @b-per . This PR is ready for review. |
Renames the KB regen workflow file (its own paths: filter already pointed at upgrading-dbt-kb.yml, so it stopped self-triggering) and updates the remaining stale upgrading-dbt-core references left over from the rename: the README skill table, the pyproject.toml package-data path, and internal prose/docstrings in the skill's schema, exec references, and scripts. Also fixes the README description to say "latest dbt" instead of "latest dbt-core".
b-per
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
correctly
Checklist
changie newto create a changelog entry