-
Notifications
You must be signed in to change notification settings - Fork 14
1425 footer concept phase 2 #5655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…hot tests for improved clarity
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…x-design-system/core-web into 1425-footer-concept-phase-2
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarahbrng why did you remove this file ?
| npm-debug.log | ||
| .history | ||
| .idea | ||
| .vscode/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .vscode/ |
this is a legitimate folder that we still would like to use.
| #### Simple | ||
|
|
||
| ```html | ||
| <db-footer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need to be the HTML tag instead of the Custom Element (like all the other following Custom Elements as well).
| const App = () => ( | ||
| <DBFooter | ||
| main={ | ||
| <div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need to be an unordered list. Let's align on this topic.
| /* Styles for the showcases */ | ||
| .desktop-navigation ul { | ||
| list-style-type: ""; | ||
| list-style-type: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| list-style-type: none; | |
| list-style-type: ""; |
The value 'none' results in a Safari VoiceOver behaviour we'd like to mitigate.
Proposed changes
Erstellung der Footer Komponente
resolves #1425
Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/1425-footer-concept-phase-2