Use PIL for image resizing#16
Open
UPstartDeveloper wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello - this PR is related to #14
Notes:
PILfor this change, since it looks like theinterpolate()function from PyTorch doesn't support Lanczos interpolations yet.Image.resize()function from Pillow doesn't support cubic interpolations. For now, I just left outcubicas an option, but I am wondering when someone might actually want to use it in 2D image processing. What do you think?display_tree()anddisplay_helper()functions (found infull-vqa-example.ipynbandvisualize-output.ipynbrespectively) to also allow users to pass in‘box’or‘hamming’for theinterpparameter..gitignorefile to the repo, mainly to avoid pushing my local copy of theclevr-reg-hres.ptbinary file.Looking forward to hear what others think of these changes!