Skip to content

Use PIL for image resizing#16

Open
UPstartDeveloper wants to merge 1 commit into
davidmascharka:masterfrom
UPstartDeveloper:imresize
Open

Use PIL for image resizing#16
UPstartDeveloper wants to merge 1 commit into
davidmascharka:masterfrom
UPstartDeveloper:imresize

Conversation

@UPstartDeveloper
Copy link
Copy Markdown

@UPstartDeveloper UPstartDeveloper commented Dec 7, 2021

Hello - this PR is related to #14

Notes:

  1. I decided to go with PIL for this change, since it looks like the interpolate() function from PyTorch doesn't support Lanczos interpolations yet.
  2. On the same token, the Image.resize() function from Pillow doesn't support cubic interpolations. For now, I just left out cubic as an option, but I am wondering when someone might actually want to use it in 2D image processing. What do you think?
  3. Next, I expanded the docstrings in the display_tree() and display_helper() functions (found in full-vqa-example.ipynb and visualize-output.ipynb respectively) to also allow users to pass in ‘box’ or ‘hamming’ for the interp parameter.
  4. Finally, I added a .gitignore file to the repo, mainly to avoid pushing my local copy of the clevr-reg-hres.pt binary file.

Looking forward to hear what others think of these changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant