Skip to content

feat(glossary): surface deprecation badge on glossary term tree#18156

Open
datahub-akshay wants to merge 1 commit into
datahub-project:masterfrom
datahub-akshay:feat/glossary-term-deprecation-tree
Open

feat(glossary): surface deprecation badge on glossary term tree#18156
datahub-akshay wants to merge 1 commit into
datahub-project:masterfrom
datahub-akshay:feat/glossary-term-deprecation-tree

Conversation

@datahub-akshay

@datahub-akshay datahub-akshay commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds deprecation { ...deprecationFields } to the childGlossaryTerm fragment in glossaryNode.graphql so the glossary sidebar tree query fetches a term's deprecation status
  • Renders the existing DeprecationIcon next to a term's name in TermItem.tsx when deprecation.deprecated is true, following the same pattern already used for tags, domains, and data products
  • Reuses the isOnEntityPage ? entityData : term fallback already in place for getDisplayName, so the badge reflects live state immediately after deprecating/un-deprecating from the term's own profile page, and falls back to the sidebar-fetched value otherwise
Screenshot 2026-07-02 at 1 31 17 PM

Test plan

  • TermItem.test.tsx (new): 7 cases covering deprecated / not-deprecated / null / absent deprecation, plus the live entityData override behavior (shows live state, clears a stale badge, falls back correctly when entityData belongs to a different entity)
  • yarn vitest run on the new test file: all passing
  • eslint on changed files: clean
  • tsc --noEmit: no errors
  • GlossaryTerm.deprecation already exists on the backend schema, so no server-side change was needed

Note: glossaryNode.generated.ts is gitignored and not part of this diff; run yarn generate after pulling this branch to pick up the updated fragment types.

Adds the deprecation aspect to the childGlossaryTerm fragment and
renders the existing DeprecationIcon next to term names in the
glossary sidebar tree, following the same pattern already used for
tags, domains, and data products.
@github-actions github-actions Bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Jul 3, 2026
@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Jul 3, 2026
@lakshay-nasa lakshay-nasa removed the community-contribution PR or Issue raised by member(s) of DataHub Community label Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants