feat(glossary): surface deprecation badge on glossary term tree#18156
Open
datahub-akshay wants to merge 1 commit into
Open
feat(glossary): surface deprecation badge on glossary term tree#18156datahub-akshay wants to merge 1 commit into
datahub-akshay wants to merge 1 commit into
Conversation
Adds the deprecation aspect to the childGlossaryTerm fragment and renders the existing DeprecationIcon next to term names in the glossary sidebar tree, following the same pattern already used for tags, domains, and data products.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deprecation { ...deprecationFields }to thechildGlossaryTermfragment inglossaryNode.graphqlso the glossary sidebar tree query fetches a term's deprecation statusDeprecationIconnext to a term's name inTermItem.tsxwhendeprecation.deprecatedis true, following the same pattern already used for tags, domains, and data productsisOnEntityPage ? entityData : termfallback already in place forgetDisplayName, so the badge reflects live state immediately after deprecating/un-deprecating from the term's own profile page, and falls back to the sidebar-fetched value otherwiseTest plan
TermItem.test.tsx(new): 7 cases covering deprecated / not-deprecated / null / absent deprecation, plus the liveentityDataoverride behavior (shows live state, clears a stale badge, falls back correctly whenentityDatabelongs to a different entity)yarn vitest runon the new test file: all passingeslinton changed files: cleantsc --noEmit: no errorsGlossaryTerm.deprecationalready exists on the backend schema, so no server-side change was neededNote:
glossaryNode.generated.tsis gitignored and not part of this diff; runyarn generateafter pulling this branch to pick up the updated fragment types.