fix(auth): stop logging bearer tokens in DataHubOAuthAuthenticator#18140
Merged
max-datahub merged 1 commit intoJul 2, 2026
Merged
Conversation
The OAuth authenticator logged the full request header map at INFO on every authentication attempt, which includes the Authorization header (the bearer JWT). This wrote live credentials into normal application logs. This was leftover debug logging. Remove the line entirely. If header diagnostics are ever needed, they should be added at DEBUG with the Authorization value redacted. Impact: any deployment with external OAuth authentication enabled. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Max Margalith <max.margalith@datahub.com>
Bundle ReportBundle size has no change ✅ |
RyanHolstien
approved these changes
Jul 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataHubOAuthAuthenticatorlogged the entire request header map atINFOonevery authentication attempt:
The header map includes the
Authorizationheader — i.e. the full bearer JWT.This wrote live credentials into normal application logs, which are commonly
shipped to centralized logging, retained, and indexed. The line was leftover
debug logging.
This PR removes the line entirely. No replacement is added: the token is never
needed in logs. If header diagnostics are ever wanted in the future, they should
be added at
DEBUGwith theAuthorizationvalue redacted.Impact: any deployment with external OAuth authentication enabled was
exposing bearer tokens in its logs.
Checklist
🤖 Generated with Claude Code