perf(frontend): reduce initial load of FE bundle#18109
Conversation
|
🔴 Meticulous spotted visual differences in 161 of 1246 screens tested: view and approve differences detected. Meticulous evaluated ~10 hours of user flows against your PR. Last updated for commit |
Initial JS bundle size
|
Bundle ReportChanges will increase total bundle size by 147.28kB (0.48%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Initial JS bundle size 🟢
|
chriscollins3456
left a comment
There was a problem hiding this comment.
def a fan of removing the old Editor component and consolidating on the one in alchemy-components
| // from the initial bundle. Callers keep the same <Editor /> API including ref forwarding. | ||
| export const Editor = forwardRef<unknown, EditorProps>((props, ref) => ( | ||
| <Suspense fallback={null}> | ||
| <EditorImpl {...props} ref={ref} /> |
There was a problem hiding this comment.
this change doesn't cause the editor to be loaded laggily or anything? did it feel good locally when you tested it?
There was a problem hiding this comment.
I tested with throttling on 3G and the editor still loaded almost instantly.
Summary
Drive-by
@mui/icons-materialimports for visually equivalent Phosphor CSR path imports (@phosphor-icons/react/dist/csr/X)