fix(frontend): respect basePath in user list links#18103
Open
nrogerarkhn wants to merge 1 commit into
Open
Conversation
Contributor
|
Linear: CAT-2532 Thanks for your contribution! We have created an internal ticket to track this PR. A member of the core DataHub team will be assigned to review it within the next few business days - you will get a follow-up comment once a reviewer is assigned. |
Bundle ReportChanges will decrease total bundle size by 11 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
There is a bug where the users URL is not rendered properly (basePath missing in the Manage Users & Groups settings view), while the groups URL is.
What
UserListV2uses a<a href>instead of a<Link>, harmonized that.Test Summary —
UserListV2.components.tsx--fix)tsc --noEmit)src/app/identity/user)The non-passing test in on
SimpleSelectRole.test.tsx, it was pre-existing to this change (confirmed with a stash).Do not hesitate if something is not quite right here, or if I made a mistake!