Skip to content

fix(frontend): respect basePath in user list links#18103

Open
nrogerarkhn wants to merge 1 commit into
datahub-project:masterfrom
nrogerarkhn:master
Open

fix(frontend): respect basePath in user list links#18103
nrogerarkhn wants to merge 1 commit into
datahub-project:masterfrom
nrogerarkhn:master

Conversation

@nrogerarkhn

@nrogerarkhn nrogerarkhn commented Jun 30, 2026

Copy link
Copy Markdown

Why

There is a bug where the users URL is not rendered properly (basePath missing in the Manage Users & Groups settings view), while the groups URL is.

What

UserListV2 uses a <a href> instead of a <Link>, harmonized that.

Test Summary — UserListV2.components.tsx

Check Result
ESLint (--fix) ✅ Clean — no issues
Prettier ✅ All matched files use Prettier code style
Type-check (tsc --noEmit) ✅ No errors in the changed file
Unit tests (src/app/identity/user) ✅ 82 / 83 passed

The non-passing test in on SimpleSelectRole.test.tsx, it was pre-existing to this change (confirmed with a stash).


Do not hesitate if something is not quite right here, or if I made a mistake!

@github-actions github-actions Bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Jun 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Linear: CAT-2532

Thanks for your contribution! We have created an internal ticket to track this PR. A member of the core DataHub team will be assigned to review it within the next few business days - you will get a follow-up comment once a reviewer is assigned.

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 11 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 30.37MB -11 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -11 bytes 9.01MB -0.0%

Files in assets/index-*.js:

  • ./src/app/identity/user/UserListV2.components.tsx → Total Size: 6.5kB

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution PR or Issue raised by member(s) of DataHub Community needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants