Skip to content

icon table fix#16641

Open
benjiaming wants to merge 28 commits into
masterfrom
CAT-1335-followup
Open

icon table fix#16641
benjiaming wants to merge 28 commits into
masterfrom
CAT-1335-followup

Conversation

@benjiaming

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

PR Title Check Failed

Your PR title must follow the format: <type>[optional scope]: <description>

Examples:

  • feat(ingestion): add Snowflake v2 source
  • fix: resolve crash on empty dashboard

See the Contributing Guide for allowed types and format details.

@github-actions github-actions Bot added the product PR or Issue related to the DataHub UI/UX label Mar 18, 2026
@alwaysmeticulous

alwaysmeticulous Bot commented Mar 18, 2026

Copy link
Copy Markdown

🔴 Meticulous spotted visual differences in 17 of 1702 screens tested: view and approve differences detected.

Meticulous evaluated ~10 hours of user flows against your PR.

Last updated for commit d75c440. This comment will update as new commits are pushed.

@codecov

codecov Bot commented Mar 18, 2026

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 3.14kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 23.78MB -3.14kB (-0.01%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -3.14kB 13.6MB -0.02%

Files in assets/index-*.js:

  • ./src/alchemy-components/components/Table/Table.tsx → Total Size: 7.82kB

@codecov

codecov Bot commented Mar 18, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
342 1 341 0
View the top 2 failed test(s) by shortest run time
create and manage platform and metadata policies cypress/e2e/settingsV2/v2_manage_policies.js::cypress/e2e/settingsV2/v2_manage_policies.js
Stack Traces | 26.5s run time
2026-03-18T01:11:36.107Z
`cy.type()` failed because it targeted a disabled element.

The element typed into was:

  > <input placeholder="Search policies..." data-testid="search-bar-input" class="ant-input" type="text" value="">

Ensure the element does not have an attribute named `disabled` before typing into it.

https://on.cypress.io/type
tests.cypress.integration_test::test_run_cypress
Stack Traces | 292s run time
auth_session = <tests.utils.TestSessionWrapper object at 0x7f2d340669d0>

    def test_run_cypress(auth_session):
        # Run with --record option only if CYPRESS_RECORD_KEY is non-empty
        record_key = env_vars.get_cypress_record_key()
        tag_arg = ""
        test_strategy = env_vars.get_test_strategy()
        if record_key:
            record_arg = " --record "
            batch_number = os.getenv("BATCH_NUMBER")
            batch_count = os.getenv("BATCH_COUNT")
            if batch_number and batch_count:
                batch_suffix = f"-{batch_number}{batch_count}"
            else:
                batch_suffix = ""
            tag_arg = f" --tag {test_strategy}{batch_suffix}"
        else:
            record_arg = " "
    
        logger.info(f"test strategy is {test_strategy}")
        test_spec_arg = ""
        specs_str = ",".join([f"**/{f}" for f in _get_filtered_or_batched_tests()])
        test_spec_arg = f" --spec '{specs_str}' "
    
        logger.info("Running Cypress tests with command")
        node_options = "--max-old-space-size=500"
        electron_args = 'ELECTRON_EXTRA_LAUNCH_ARGS="--js-flags=\'--max-old-space-size=4096 --disable-dev-shm-usage --disable-gpu --no-sandbox"'
        command = f'{electron_args} NO_COLOR=1 NODE_OPTIONS="{node_options}" npx cypress run {record_arg} {test_spec_arg} {tag_arg}'
        logger.info(command)
        # Add --headed --spec '**/mutations/mutations.js' (change spec name)
        # in case you want to see the browser for debugging
        print_now()
        proc = subprocess.Popen(
            command,
            shell=True,
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
            cwd=f"{CYPRESS_TEST_DATA_DIR}",
            text=True,  # Use text mode for string output
            bufsize=1,  # Line buffered
        )
        assert proc.stdout is not None
        assert proc.stderr is not None
    
        # Function to read and print output from a pipe
        def read_and_print(pipe, prefix=""):
            for line in pipe:
                logger.info(f"{prefix}{line.rstrip()}")
    
        # Read and print output in real-time
    
        stdout_thread = threading.Thread(target=read_and_print, args=(proc.stdout,))
        stderr_thread = threading.Thread(
            target=read_and_print, args=(proc.stderr, "stderr: ")
        )
    
        # Set threads as daemon so they exit when the main thread exits
        stdout_thread.daemon = True
        stderr_thread.daemon = True
    
        # Start the threads
        stdout_thread.start()
        stderr_thread.start()
    
        # Wait for the process to complete
        return_code = proc.wait()
    
        # Wait for the threads to finish
        stdout_thread.join()
        stderr_thread.join()
    
        logger.info(f"return code: {return_code}")
        print_now()
>       assert return_code == 0
E       assert 1 == 0

tests/cypress/integration_test.py:343: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Base automatically changed from CAT-1335-refactor-icon to master March 18, 2026 03:17
@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants