perf: remove momentjs by benjiaming · Pull Request #16615 · datahub-project/datahub

benjiaming · 2026-03-16T21:51:29Z

Replace moment.js with day.js.

Scope: 30 files use moment, 11 use moment-timezone. API is nearly identical.

Net saving: ~318 KB gz. Risk: Low (API compatible, dayjs already in bundle, timezone plugin already used in 3 places).

github-actions · 2026-03-16T21:51:41Z

Linear: CAT-1535

alwaysmeticulous · 2026-03-16T21:56:19Z

✅ Meticulous spotted 0 visual differences across 1523 screens tested: view results.

Meticulous evaluated ~9 hours of user flows against your PR.

_{Expected differences? Click here. Last updated for commit 4477b54. This comment will update as new commits are pushed.}

codecov · 2026-03-16T22:50:34Z

Bundle Report

Changes will decrease total bundle size by 234.63kB (-1.02%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	22.73MB	-234.63kB (-1.02%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	-315.72kB	12.5MB	-2.46%
*`assets/flinklogo-.svg`** (New)	81.09kB	81.09kB	100.0% 🚀

Files in assets/index-*.js:

./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/StatsV2/components/sections/ChartsSection/charts/components/MetricChartPopover.tsx → Total Size: 435 bytes
./src/alchemy-components/components/DatePicker/components.tsx → Total Size: 908 bytes
./src/app/entityV2/shared/notes/NotesSection.tsx → Total Size: 5.27kB
./src/app/entity/shared/containers/profile/sidebar/FormInfo/VerificationAuditStamp.tsx → Total Size: 700 bytes
./src/app/analyticsDashboardV2/components/AnalyticsChart.tsx → Total Size: 16.12kB
./src/app/entityV2/shared/sidebarSection/SidebarNotesSection.tsx → Total Size: 401 bytes
./src/app/entityV2/shared/containers/profile/sidebar/shared/utils.tsx → Total Size: 2.27kB
./src/app/entityV2/document/changeHistory/DocumentChangeTimelineContent.tsx → Total Size: 1.57kB
./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/StatsV2/components/sections/ChartsSection/charts/hooks/useGetBottomAxisPropsByLookbackWindowType.ts → Total Size: 480 bytes
./src/alchemy-components/components/LineChart/defaults.tsx → Total Size: 1.82kB
./src/app/entityV2/shared/EntityDropdown/UpdateDeprecationModal.tsx → Total Size: 5.61kB
./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/SchemaFieldQueriesSidebarTab.tsx → Total Size: 4.78kB
./src/app/entityV2/shared/graphs/RowCountGraph.tsx → Total Size: 1.58kB
./src/alchemy-components/components/BarChart/defaults.ts → Total Size: 959 bytes
./src/app/entityV2/shared/components/styled/DeprecationIcon.tsx → Total Size: 6.11kB
./src/app/entity/shared/containers/profile/sidebar/LastIngested.tsx → Total Size: 5.96kB
./src/app/entityV2/shared/containers/profile/sidebar/shared/TimeProperty.tsx → Total Size: 857 bytes
./src/app/entity/shared/EntityDropdown/UpdateDeprecationModal.tsx → Total Size: 2.3kB
./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/AboutFieldTab.tsx → Total Size: 3.32kB
./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/StatsV2/utils.ts → Total Size: 421 bytes
./src/app/entityV2/shared/tabs/Dataset/Queries/useQueryTableColumns.tsx → Total Size: 4.64kB
./src/alchemy-components/components/BarChart/utils.ts → Total Size: 506 bytes
./src/app/entity/shared/components/styled/StructuredProperty/DateInput.tsx → Total Size: 330 bytes
./src/alchemy-components/components/CalendarChart/utils.ts → Total Size: 3.31kB

codecov · 2026-03-17T01:11:03Z

Codecov Report

❌ Patch coverage is 84.61538% with 8 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...chemy-components/components/CalendarChart/utils.ts	40.00%	3 Missing ⚠️
...searchV2/filters/value/useDateRangeFilterValues.ts	33.33%	2 Missing ⚠️
...storyGraph/components/ChangeHistoryDrawer/utils.ts	75.00%	1 Missing ⚠️
...s/ChangeHistoryGraph/hooks/useChangeHistoryData.ts	50.00%	1 Missing ⚠️
...sTabV2/graphs/QueryCountGraph/useQueryCountData.ts	50.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

ani-malgari

Looks like we're also importing dayjs directly in some places and when we call it's functions, it silently depends on it's plugins having to be imported in @utils/dayjs and might throw an error if dayjs hasn't been mutated already. The patterns are also inconsistent in some places.

The ideal case is to use @utils/dayjs in all imports, and enforce a ESLint rule to import from utils. It can increase the scope of the PR, and it's okay if we want to do a separate immediate follow-up PR.

benjiaming · 2026-03-17T19:22:19Z

Looks like we're also importing dayjs directly in some places and when we call it's functions, it silently depends on it's plugins having to be imported in @utils/dayjs and might throw an error if dayjs hasn't been mutated already. The patterns are also inconsistent in some places.

The ideal case is to use @utils/dayjs in all imports, and enforce a ESLint rule to import from utils. It can increase the scope of the PR, and it's okay if we want to do a separate immediate follow-up PR.

I agree! Thanks for flagging this.

ani-malgari

the PR looks great except i have two comments:

In datahub-web-react/src/app/search/filters/utils.tsx, we've replaced a constant with a prop and not passing this prop from the callers. i'm afraid this will break or return an undesired color, we need to fix this before we merge.
also curious why we still have moment in lock file. is it a caching issue?

ani-malgari · 2026-03-23T18:59:51Z

-    moment ">= 2.9.0"
-
-"moment@>= 2.9.0", moment@^2.24.0, moment@^2.29.2, moment@^2.29.4:
+moment@^2.24.0, moment@^2.29.2:


do you know what this is for?

moment is still pulled in by Antd. The 360kB reduction in bundle is from dropping moment-timezone.

ani-malgari · 2026-03-23T19:01:17Z

    filterEntity: Entity | null,
    entityRegistry: EntityRegistry,
    size?: number,
+    iconColor?: string,


why are we creating a new prop for iconColor, which was earlier a constant?

and we haven't updated iconColor to the caller of this function. this i'm afraid will break or return an undesired default color at the entityRegistry.getIcon call.

You're right. The proper fix would be to useTheme and get color from there in all locations but that's outside of the scope of this PR. Since the eslint rule is now disabled, I will revert to original code.

AdrianMachado · 2026-03-23T19:56:53Z


 export const TimezoneSelect = ({ value, onChange }: Props) => {
-    const timezones = moment.tz.names();
+    const timezones = (Intl as any).supportedValuesOf('timeZone') as string[];


why do we need to do a cast here?

We use Typescript 4.8.4 and according to microsoft/TypeScript#49231 supportedValuesOf landed somewhere in 5.x. I suppose we could extend Intl namespace manually, as suggested in the issue but I think any might be ok here.

AdrianMachado · 2026-03-23T19:57:51Z


 export const TimezoneSelect = ({ value, onChange }: Props) => {
-    const timezones = moment.tz.names();
+    const timezones = (Intl as any).supportedValuesOf('timeZone') as string[];


Does dayjs not provide a list of timezones?

I don't think it does: https://day.js.org/docs/en/timezone/timezone

AdrianMachado · 2026-03-23T20:01:22Z

-    const hours = Math.floor(duration.asHours());
-    const minutes = duration.minutes();
-    const seconds = duration.seconds();
+    const dur = dayjs.duration(durationMs);


nit: I don't think there's a strong reason to shorten the name here

Conflicts resolved by Claude AI. Merged from commit 6c8f95a Original author: Ben Blazke <benjiaming@users.noreply.github.com>

benjiaming added 2 commits March 16, 2026 14:42

CAT-1534: remove momentjs

91d0d75

CAT-1534: remove momentjs

5390211

github-actions Bot added the product PR or Issue related to the DataHub UI/UX label Mar 16, 2026

github-actions Bot deployed to datahub-project-web-react (Preview) March 16, 2026 21:55 View deployment

vercel Bot had a problem deploying to Preview March 16, 2026 22:00 Failure

ci

7ef7bbc

benjiaming changed the title ~~Cat 1534 remove momentjs~~ perf: remove momentjs Mar 16, 2026

github-actions Bot deployed to datahub-project-web-react (Preview) March 16, 2026 23:09 View deployment

vercel Bot had a problem deploying to Preview March 16, 2026 23:12 Failure

ci

e4257bf

github-actions Bot deployed to datahub-project-web-react (Preview) March 17, 2026 00:47 View deployment

vercel Bot had a problem deploying to Preview March 17, 2026 00:50 Failure

maggiehays added the needs-review Label for PRs that need review from a maintainer. label Mar 17, 2026

ani-malgari reviewed Mar 17, 2026

View reviewed changes

Comment thread datahub-web-react/src/alchemy-components/components/CalendarChart/utils.ts Outdated

ani-malgari reviewed Mar 17, 2026

View reviewed changes

Comment thread datahub-web-react/.eslintrc.js

ani-malgari reviewed Mar 17, 2026

View reviewed changes

AdrianMachado reviewed Mar 17, 2026

View reviewed changes

Comment thread datahub-web-react/src/utils/dayjs.ts Outdated

benjiaming added 2 commits March 17, 2026 18:00

dayjs eslint rule

04861bd

code reviews

e9d6b6f

github-actions Bot deployed to datahub-project-web-react (Preview) March 18, 2026 01:10 View deployment

vercel Bot had a problem deploying to Preview March 18, 2026 01:15 Failure

Merge branch 'master' into CAT-1534-remove-momentjs

afb45da

github-actions Bot deployed to datahub-project-web-react (Preview) March 18, 2026 21:54 View deployment

vercel Bot deployed to Preview March 18, 2026 22:04 View deployment

Merge branch 'master' into CAT-1534-remove-momentjs

52bd703

github-actions Bot deployed to datahub-project-web-react (Preview) March 19, 2026 19:10 View deployment

vercel Bot deployed to Preview March 19, 2026 19:22 View deployment

conflict resolved

96e61f1

github-actions Bot deployed to datahub-project-web-react (Preview) March 20, 2026 18:50 View deployment

vercel Bot deployed to Preview March 20, 2026 19:03 View deployment

benjiaming enabled auto-merge (squash) March 20, 2026 19:25

conflict resolution

bc5d311

github-actions Bot deployed to datahub-project-web-react (Preview) March 20, 2026 20:45 View deployment

vercel Bot deployed to Preview March 20, 2026 20:57 View deployment

Merge branch 'master' into CAT-1534-remove-momentjs

c3a412f

vercel Bot deployed to Preview March 20, 2026 21:25 View deployment

Merge branch 'master' into CAT-1534-remove-momentjs

ed559a6

github-actions Bot deployed to datahub-project-web-react (Preview) March 21, 2026 00:19 View deployment

vercel Bot deployed to Preview March 21, 2026 00:31 View deployment

ani-malgari reviewed Mar 23, 2026

View reviewed changes

AdrianMachado reviewed Mar 23, 2026

View reviewed changes

maggiehays added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Mar 23, 2026

benjiaming added 2 commits March 23, 2026 15:06

code reviews

779e9cd

code reviews

4477b54

github-actions Bot deployed to datahub-project-web-react (Preview) March 23, 2026 22:20 View deployment

benjiaming requested review from AdrianMachado and ani-malgari March 23, 2026 22:27

vercel Bot deployed to Preview March 23, 2026 22:32 View deployment

AdrianMachado approved these changes Mar 23, 2026

View reviewed changes

benjiaming merged commit 6c8f95a into master Mar 23, 2026
39 checks passed

benjiaming deleted the CAT-1534-remove-momentjs branch March 23, 2026 23:37

david-leifker pushed a commit that referenced this pull request May 27, 2026

Merge 6c8f95a: perf: remove momentjs (#16615)

83fda6f

Conflicts resolved by Claude AI. Merged from commit 6c8f95a Original author: Ben Blazke <benjiaming@users.noreply.github.com>

AdrianMachado mentioned this pull request Jun 5, 2026

fix(ui): Fix regression in timezone availability #17757

Merged

Uh oh!

Conversation

benjiaming commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 16, 2026

Uh oh!

alwaysmeticulous Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov Bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

ani-malgari left a comment

Choose a reason for hiding this comment

Uh oh!

benjiaming commented Mar 17, 2026

Uh oh!

Uh oh!

ani-malgari left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

benjiaming commented Mar 16, 2026 •

edited

Loading

alwaysmeticulous Bot commented Mar 16, 2026 •

edited

Loading

codecov Bot commented Mar 16, 2026 •

edited

Loading

codecov Bot commented Mar 17, 2026 •

edited

Loading