Skip to content

MDS Schema 3 Deprecation Tasks.#71

Merged
svogt0511 merged 3 commits intomasterfrom
schema-3-dep
Jan 8, 2025
Merged

MDS Schema 3 Deprecation Tasks.#71
svogt0511 merged 3 commits intomasterfrom
schema-3-dep

Conversation

@svogt0511
Copy link
Contributor

Purpose

In MDS, creating/updating a DOI calls lupo which does the checking and sends back the appropriate error. That mechanism already exists.

The only task that needs to be done is to add appropriate tests.

Spec Documents

closes: #70

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@svogt0511 svogt0511 self-assigned this Oct 26, 2024
Copy link

@codycooperross codycooperross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@jrhoads
Copy link
Contributor

jrhoads commented Nov 15, 2024

The code changes look good to me.
I think this PR could do with a rebase after #68 and #72.
Then the CI testing should work.

@svogt0511 svogt0511 merged commit dabedd1 into master Jan 8, 2025
2 checks passed
@svogt0511 svogt0511 deleted the schema-3-dep branch January 8, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MDS Schema 3 Deprecation Tasks

3 participants