-
Notifications
You must be signed in to change notification settings - Fork 128
pipelines: add generate command #4251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ed6f29d to
b71da84
Compare
|
Commit: 2d546c1
30 interesting tests: 13 RECOVERED, 10 KNOWN, 6 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
lennartkats-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested
| // YAML paths are relative to directory containing YAML file, in this case: | ||
| // DAB YAML is in "./resources/<directoryName>.pipeline.yml" | ||
| // SDP YAML is in "./<pipelineDirectoryPath>/spark-pipeline.yml" | ||
| // NB: all paths are /-based so Windows has the same output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: that's a lotta comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷 These are non-AI comments I wrote by hand. I think it's helpful to have them, otherwise, paths are tricky because they are typed as strings and it's hard to follow in which format they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't even tell anymore 😭 You can keep them
|
Commit: 008b72a
34 interesting tests: 15 RECOVERED, 10 KNOWN, 8 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Changes
Add
databricks pipelines generatecommand that generates DAB resources from SDP YAML.generatecommand is tailored tolakeflow-pipelinestemplate wheresrcfolder contains pipeline folders, for example:Usage
Where
src/my_pipeline/sdp-pipeline.yml:Produces
resources/my_pipeline.pipeline.yml:Why
It allows creating DAB YAML for Spark Declarative Pipelines
Tests
Acceptance and unit tests