refactor(query): phase 1 of removing global service lookups#19638
Open
forsaken628 wants to merge 3 commits intodatabendlabs:mainfrom
Open
refactor(query): phase 1 of removing global service lookups#19638forsaken628 wants to merge 3 commits intodatabendlabs:mainfrom
forsaken628 wants to merge 3 commits intodatabendlabs:mainfrom
Conversation
070ae73 to
0e237e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR is the first phase of removing global variables and global singleton lookups from the query layer.
In this phase, the focus is on introducing context-bound service access and migrating a low-risk subset of callsites away from direct global reads. The branch adds a generic
service registry/provider abstraction, makes session/query/table contexts able to expose registered services, and starts switching callers from GlobalInstance / ::instance()
style access to context-based lookup.
Key changes:
Scope of phase 1:
Tests
Type of change
This change is