Skip to content

fix(key-wallet): stop a never-broadcast transaction from crediting money that does not exist - #961

Merged
QuantumExplorer merged 16 commits into
devfrom
fix/phantom-unconfirmed-balance
Aug 14, 2026
Merged

fix(key-wallet): stop a never-broadcast transaction from crediting money that does not exist#961
QuantumExplorer merged 16 commits into
devfrom
fix/phantom-unconfirmed-balance

feat(dash-spv-ffi): expose the sweep as a C callback

ed360cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 14, 2026 in 1s

76.64% (+0.16%) compared to 0f94859

View this Pull Request on Codecov

76.64% (+0.16%) compared to 0f94859

Details

Codecov Report

❌ Patch coverage is 91.83168% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.64%. Comparing base (0f94859) to head (ed360cc).
⚠️ Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
dash-spv-ffi/src/callbacks.rs 3.22% 30 Missing ⚠️
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% 23 Missing ⚠️
key-wallet-manager/src/lib.rs 9.09% 20 Missing ⚠️
.../src/managed_account/managed_core_funds_account.rs 91.04% 12 Missing ⚠️
key-wallet-manager/src/events.rs 0.00% 9 Missing ⚠️
...-wallet/src/managed_account/managed_account_ref.rs 88.88% 2 Missing ⚠️
...-wallet/src/transaction_checking/wallet_checker.rs 99.76% 2 Missing ⚠️
...y-wallet/src/wallet/managed_wallet_info/helpers.rs 98.94% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #961      +/-   ##
==========================================
+ Coverage   76.48%   76.64%   +0.16%     
==========================================
  Files         329      329              
  Lines       80525    81947    +1422     
==========================================
+ Hits        61590    62810    +1220     
- Misses      18935    19137     +202     
Files with missing lines Coverage Δ
key-wallet-manager/src/process_block.rs 92.30% <ø> (ø)
.../src/managed_account/managed_account_collection.rs 65.40% <100.00%> (+0.33%) ⬆️
...wallet/src/transaction_checking/account_checker.rs 54.35% <100.00%> (+0.37%) ⬆️
key-wallet/src/wallet/managed_wallet_info/mod.rs 74.22% <ø> (ø)
...allet/managed_wallet_info/wallet_info_interface.rs 80.47% <100.00%> (+0.68%) ⬆️
...y-wallet/src/wallet/managed_wallet_info/helpers.rs 62.93% <98.94%> (+17.91%) ⬆️
...-wallet/src/managed_account/managed_account_ref.rs 53.41% <88.88%> (+2.50%) ⬆️
...-wallet/src/transaction_checking/wallet_checker.rs 99.45% <99.76%> (+0.20%) ⬆️
key-wallet-manager/src/events.rs 64.92% <0.00%> (-2.90%) ⬇️
.../src/managed_account/managed_core_funds_account.rs 83.00% <91.04%> (+2.96%) ⬆️
... and 3 more

... and 31 files with indirect coverage changes