build: update rust-dashcore to 2824e52a

[lklimek]

Issue being fixed or feature implemented

Update rust-dashcore dependency to latest commit (2824e52a), bringing in 34 upstream commits including dropped FeeLevel/FeeEstimator, new clear_in_flight_state() on SyncManager, transaction broadcast FFI, and various refactors.

What was done?

• Updated all 6 workspace rust-dashcore dependencies (dashcore, dash-spv, dash-spv-ffi, key-wallet, key-wallet-manager, dashcore-rpc) from a05d256f → 2824e52a
• Removed create_unsigned_payment_transaction from PlatformWalletInfo's WalletInfoInterface impl (method removed upstream from the trait)
• Removed dead imports: FeeLevel, TransactionError, Address

How Has This Been Tested?

• cargo check --workspace passes with no errors
• cargo fmt --all and cargo clippy pass (pre-commit hooks)

Breaking Changes

None for platform consumers. The removed create_unsigned_payment_transaction on PlatformWalletInfo was a pass-through to ManagedWalletInfo which no longer exposes it.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

_{🤖 Co-authored by Claudius the Magnificent AI Agent}

Summary by CodeRabbit

• Chores

  • Updated internal dependencies to latest versions.

• Refactor

  • Simplified internal wallet interface by removing unused transaction creation functionality.

[coderabbitai]

📝 Walkthrough

Walkthrough

Workspace git dependencies in Cargo.toml were updated for six crates (dashcore, dash-spv, dash-spv-ffi, key-wallet, key-wallet-manager, dashcore-rpc) to a new revision. The create_unsigned_payment_transaction method was removed from PlatformWalletInfo implementation, along with related imports.

Changes

Cohort / File(s)	Summary
Workspace Dependency Updates Cargo.toml	Updated git revisions for six workspace dependencies from a05d256f59743c69df912462dd77dd487e1ff5b2 to 2824e52a3845d5f595fd5a113193bbc6cca72d6a.
PlatformWalletInfo Implementation Cleanup packages/rs-platform-wallet/src/lib.rs	Removed create_unsigned_payment_transaction method from WalletInfoInterface implementation and eliminated associated imports (FeeLevel, AccountTypePreference, TransactionError, and wallet UI types).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Off with the old code, away with the clutter,
Dependencies updated, no more a flutter!
Methods removed with a hoppy delight,
The wallet shines cleaner—a beautiful sight! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately identifies the main change: updating rust-dashcore dependency to a new commit revision (2824e52a).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/update-rust-dashcore

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[thepastaclaw]

Reviewed the diff and the 34 upstream commits (a05d256f..2824e52a).

Changes look correct:

• create_unsigned_payment_transaction was removed from the WalletInfoInterface trait upstream (rust-dashcore#483), so removing it from the PlatformWalletInfo impl is required
• Dead imports (FeeLevel, AccountTypePreference, TransactionError, Address) properly cleaned up
• No new required trait methods were added that would need implementation here
• Cargo.lock updates are consistent with the Cargo.toml rev changes

LGTM 👍