Repository navigation
fix: return REST errors for unavailable deployment data - #7818
PastaPastaPasta merged 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Final review complete — no blockers (commit 2226682) · triage: low · Phase 2 only (queue backlog) |
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 2 only (queue backlog)
Verified the supplied Phase-2 assessments against head 2226682 and the complete one-commit PR range; no in-scope defects were identified. The REST handler catches RPC and standard exceptions before writing success headers, preserves existing validation and successful responses, and adds functional coverage for missing block data, continued service, and recovery after synchronization. Verification was static only: the supplied CI snapshot shows lint and formatting passing, while source builds and other platform checks remain queued; no local builds or tests were run.
Review provenance
Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — The diff is a small, contained REST exception-handling change with a focused functional test and does not alter deployment rules or reconstruction logic. - Phase 1 reviewers: not run (skipped for throughput: 20 PRs queued, above the 10 limit)
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer,gpt-6.1-sol— dash-core-commit-history (completed, effort medium); agentphase2-reviewer
thepastaclaw
added
the
pastaclaw:approved
2 participants
Issue being fixed or feature implemented
REST deployment queries call the deployment RPC directly. When EHF reconstruction needs an unavailable block body, its exception can escape the HTTP worker. This requires REST to be enabled and the client to pass the HTTP address ACL; REST is disabled by default.
What was done?
Translate deployment RPC exceptions into a plain-text HTTP 500 response before writing successful response headers. Valid requests retain the existing JSON response. The change leaves deployment rules and reconstruction unchanged.
How Has This Been Tested?
On macOS arm64 with prebuilt depends:
make -j1,test_dash --run_test=rpc_tests,interface_rest.pywith an isolated port range, selected Python lint, whitespace lint, circular-dependency lint, andgit diff --checkpassed. The functional test requests a known post-V20 header without its body, checks the error and continued RPC/REST responses, then supplies the body and checks the successful response. The first runner attempt failed during cache startup because an HTTP port was occupied; the isolated retry passed.Independent final four-pass review completed. No pre-fix daemon termination or external exposure demonstration was performed, and the test is not claimed as a before/after crash reproduction.
Breaking Changes
Unavailable deployment reconstruction returns HTTP 500 instead of allowing an exception to escape the callback.
Checklist:
This pull request was created by Codex.