Correct the paths to config files#835
Conversation
|
This pull request has not had any activity in the past 60 days and will be closed in 365 days if not updated. Please verify it has no conflicts with the master branch and rebase if needed. Please add a comment if you need help or give permission to other people to finish your work. |
|
I think for clarity it would make sense to include an OS-reference: |
|
@anoderay I didn't mention the OS because I thought the former path covered all non-Windows OSs, but due to #852 I realize that's not the case. After your change is merged, I'd like to change all these example paths to just say "(see config file paths)", since we can't accurately describe the path in one sentence. I think we also need to correct the log paths, unless it's been done recently. I can check the Windows and Mac log paths. |
Sounds like a good idea, I'll leave this open until #852 is merged. |
|
@lefth I see you merged something here but there have been no changes to the files. |
|
@anoderay Sorry for the confusion. I sat down to make the change, but only had time to fix problems on my local repository. I've converted this change to a draft and should have time to finish it this weekend. |
|
@lefth how's it going :-) ? |
|
@anoderay Sorry about the delay. I think this change is ready for review. Note that I changed "and" to "or" in the output color profile documentation, to match the input color profile information. I gather the profile doesn't need to be copied to two folders, so "or" describes it better.
|
Phemisters
left a comment
There was a problem hiding this comment.
I think this looks good. I have left a couple of comments for consideration
Also, fix multiple full stops at end of sentence.
|
looks fine to me :-) . |
The paths to luarc files are listed on: https://docs.darktable.org/usermanual/development/en/lua/basic-principles/
The path to the local config file is listed as being in .config/, which isn't right on Windows.
I also reworded it to avoid making the description longer. I don't think we need to explain what
$HOMEmeans. If it's important to keep that explanation, longer text is necessary.