Skip to content

Correct the paths to config files#835

Open
lefth wants to merge 2 commits into
darktable-org:masterfrom
lefth:lefth-patch-1
Open

Correct the paths to config files#835
lefth wants to merge 2 commits into
darktable-org:masterfrom
lefth:lefth-patch-1

Conversation

@lefth

@lefth lefth commented Feb 17, 2026

Copy link
Copy Markdown

The paths to luarc files are listed on: https://docs.darktable.org/usermanual/development/en/lua/basic-principles/

The path to the local config file is listed as being in .config/, which isn't right on Windows.

I also reworded it to avoid making the description longer. I don't think we need to explain what $HOME means. If it's important to keep that explanation, longer text is necessary.

@github-actions

Copy link
Copy Markdown

This pull request has not had any activity in the past 60 days and will be closed in 365 days if not updated. Please verify it has no conflicts with the master branch and rebase if needed. Please add a comment if you need help or give permission to other people to finish your work.

@github-actions github-actions Bot added the no-pr-activity No activity on this PR label Apr 19, 2026
@anoderay

anoderay commented May 9, 2026

Copy link
Copy Markdown
Collaborator

I think for clarity it would make sense to include an OS-reference:
usually for Linux $HOME/.config/darktable or for Windows %LOCALAPPDATA%\darktable.

@github-actions github-actions Bot removed the no-pr-activity No activity on this PR label May 10, 2026
@lefth

lefth commented May 10, 2026

Copy link
Copy Markdown
Author

@anoderay I didn't mention the OS because I thought the former path covered all non-Windows OSs, but due to #852 I realize that's not the case. After your change is merged, I'd like to change all these example paths to just say "(see config file paths)", since we can't accurately describe the path in one sentence.

I think we also need to correct the log paths, unless it's been done recently. I can check the Windows and Mac log paths.

@anoderay

Copy link
Copy Markdown
Collaborator

After your change is merged, I'd like to change all these example paths to just say "(see config file paths)", since we can't accurately describe the path in one sentence.

Sounds like a good idea, I'll leave this open until #852 is merged.

@anoderay anoderay self-assigned this May 10, 2026
@anoderay anoderay added the blocked do not merge this yet label May 10, 2026
@anoderay

Copy link
Copy Markdown
Collaborator

@lefth #852 is merged now, could you update your pr to link to the new page?

@anoderay anoderay removed the blocked do not merge this yet label May 14, 2026
@anoderay

Copy link
Copy Markdown
Collaborator

@lefth I see you merged something here but there have been no changes to the files.

@lefth lefth marked this pull request as draft May 21, 2026 23:25
@lefth

lefth commented May 21, 2026

Copy link
Copy Markdown
Author

@anoderay Sorry for the confusion. I sat down to make the change, but only had time to fix problems on my local repository. I've converted this change to a draft and should have time to finish it this weekend.

@anoderay

anoderay commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

@lefth how's it going :-) ?

@lefth lefth marked this pull request as ready for review June 17, 2026 16:01
@lefth

lefth commented Jun 17, 2026

Copy link
Copy Markdown
Author

@anoderay Sorry about the delay. I think this change is ready for review.

Note that I changed "and" to "or" in the output color profile documentation, to match the input color profile information. I gather the profile doesn't need to be copied to two folders, so "or" describes it better.

You can provide additional profiles by placing them in $DARKTABLE/share/darktable/color/out or color/out in the darktable configuration directory

@Phemisters Phemisters left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. I have left a couple of comments for consideration

Comment thread content/preferences-settings/general.md Outdated
Comment thread content/lua/a-simple-example.md Outdated
@lefth lefth changed the title Correct the path to luarc on Windows Correct the paths to config files Jun 18, 2026
Also, fix multiple full stops at end of sentence.
@Phemisters

Copy link
Copy Markdown
Collaborator

Thank you @lefth , I think this looks ready to merge but I'll wait a day or so to give @anoderay time to comment.

@anoderay

Copy link
Copy Markdown
Collaborator

looks fine to me :-) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants