Fix tests with cfg test123 enabled - #146
Merged
Merged
Conversation
With the test123 feature enabled, Foo::new_with_raw_value returns Result<Foo, arbitrary_int::u2>. The assertion compared it against Err(3), an integer literal, causing E0308 (mismatched types) during 'cargo test --all-features'. Compare against Err(u2::new(3)) instead, mirroring the sibling assertion on the line above.
The existing debug and release test jobs only run with --no-default-features, which compiles cfg-gated test code out. This is how a compile error in the bitbybit-tests test123-gated bitenum test went undetected. Add a job that runs 'cargo test --all-features' so every feature combination is built and exercised.
danlehmann
changed the title
dgarrett
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.