first attempt at issue #2756, input-limited putnstr functions#2887
Open
zhiayang wants to merge 4 commits intodankamongmen:masterfrom
Open
first attempt at issue #2756, input-limited putnstr functions#2887zhiayang wants to merge 4 commits intodankamongmen:masterfrom
zhiayang wants to merge 4 commits intodankamongmen:masterfrom
Conversation
Author
|
@dankamongmen would appreciate a look at this if you missed it (: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Totally fell off the earth there, put the project I was doing on hiatus oops.
This is a first attempt implementing #2756; ofc the names are not final, I've just put another
nto getputnstrnandegcnetc.Some thoughts:
ncplane_putegc, so we should probably also see if we want similar things for that family of functions.ncplane_putegcactually already takes asize_t*as an out-parameter; if we didn't care about API breakage we could specify that it is also an input parameter that specifies the length of the input string. not the best idea though.