This should? (not 100% sure) fix the krew plugin entitled debug-shell#15
Open
rshutt wants to merge 2 commits intodanisla:masterfrom
Open
This should? (not 100% sure) fix the krew plugin entitled debug-shell#15rshutt wants to merge 2 commits intodanisla:masterfrom
krew plugin entitled debug-shell#15rshutt wants to merge 2 commits intodanisla:masterfrom
Conversation
the debug-shell.sh script has been changed to fix the following: * the post 1.12 extended plugin model no longer sets the ENV var that was previously expected for the namespace * somewhere along the line, `--rm` is throwing errors if you do not pass `attach=true` even though per the manpage, -i is supposed to set `attach=true`
Update debug-shell.sh for today's k8s (1.22 here)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kubectl krew debug-shellseems to be non-functional in k8s 1.22.x. I'm sure it has been broken a while. I fixed it. Now I'm contributing back.Please don't hesitate to reach out with any questions, comments, or concerns.
Regards,
--Randall