Skip to content

WIP: C++14 - #125

Open
danielknobe wants to merge 8 commits into
masterfrom
c++14
Open

WIP: C++14#125
danielknobe wants to merge 8 commits into
masterfrom
c++14

Conversation

@danielknobe

Copy link
Copy Markdown
Owner

Collection PR for c++14 improvements. Let us add everything here @ngc92 .

@danielknobe

Copy link
Copy Markdown
Owner Author

@ngc92 any other good ideas how we can improve the code?

@ngc92

ngc92 commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator

while #48 is by now quite outdated, I think overall it is a good idea.
However, right now I think we should probably prioritize getting 2.1 finished, I think.
I'm not quite sure what still remains to be done there.

@danielknobe

danielknobe commented Jun 10, 2023

Copy link
Copy Markdown
Owner Author

@ngc92
For 1.1 open issues are:
https://github.com/danielknobe/blobbyvolley2/milestone/1

I think we can move union3 if you think that is right.
I think the bots are a bit to strong on stupid level of difficulty. We should reduce the strength a bit so that new players don't get frustrated.

@ngc92

ngc92 commented Jun 10, 2023

Copy link
Copy Markdown
Collaborator

I'm fine with moving Union3.
I don't want to change things too drastically, but maybe #129 will make things more beginner friendly.

@ngc92

ngc92 commented Jun 10, 2023

Copy link
Copy Markdown
Collaborator

I think this is ready to be merged. There might be other thins that might be done better with C++14, but at least we've made the obvious changes I think.

@danielknobe danielknobe added this to the release 1.2 milestone Jun 10, 2023
@gruenich

Copy link
Copy Markdown
Contributor

Can we get this rebased and merged? It clearly is an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants