add test cases for jsonpatch where the jsonpointer "" (document root) is involved #624
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is involved * "add" specifically states that the entire document gets replaced with "value" (https://datatracker.ietf.org/doc/html/rfc6902#section-4.1) * "move", "replace", "test" and "copy" do not disallow operating on the root * "remove" does not say anything about the root either. I would say that it should be an error, since there is no such thing as an "empty" JSON document
|
Maybe related: #625 |
ItsBasi
deleted the
jsonpatch-should-account-for-document-root-being-used-as-jsonpointer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect that some of these test cases will fail the pipeline. Would need to take a closer look at the bug, but it looks like the code is treating "" (the root) as "/" (the "" key).