feat(render): the two dead deliverable params are live — quiz count caps, mindmap orientation lays out (#63)#80
Merged
Conversation
…aps, mindmap orientation lays out (#63) Two registry params were declared, validated, and then ignored — the manifest promised knobs that did nothing: interview_quiz.count produced identical output for short/standard/long, and mindmap.orientation always rendered horizontal. Validated-but-dead is worse than undeclared, and the reference manifests advertise both knobs. - quiz count: build_quiz_ir resolves the registry params like the peer projections and caps the graded questions deterministically over the SORTED ledger keys (short: 5, standard: 10, long: uncapped) so the subset is stable under manifest reordering. Discussion questions are never capped. - mindmap orientation: build_graph_ir stamps the resolved orientation into the graph-IR; build_mindmap_svg dispatches to the horizontal layout (unchanged, byte-identical output) or the new deterministic vertical layout (root on top, one column per branch, leaves stacked beneath). The shared box helper is factored out of the closure. Tests: the cap per count value (5/10/12 on a 12-cell ledger), discussion uncapped, cap stability under reordering, orientation changing the SVG while staying deterministic. Horizontal SVG verified byte-identical to the pre-change baseline; 94/94 green. Closes #63 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (#63)
Two registry params were declared, validated, and then ignored — the manifest promised knobs that did nothing:
interview_quiz.count(short | standard | long) —build_quiz_irnever read params:count: shortandcount: longproduced identical output.mindmap.orientation(horizontal | vertical) —build_graph_irignored it andbuild_mindmap_svgwas hardcoded horizontal.The registry gate happily rejected
count: shrtwhile accepting valid values that had no effect — validated-but-dead is worse than undeclared, andqbr-c-level.yamlitself advertises both knobs.Fix — both params implemented (no third state)
count—build_quiz_irresolves the registry params like the infographic/data projections already do, and caps the graded questions deterministically over the sorted ledger keys:short: 5,standard: 10,long: uncapped. The sorted cut makes the subset stable under manifest reordering; discussion questions are never capped.orientation—build_graph_irstamps the resolved orientation into the graph-IR;build_mindmap_svgdispatches to the horizontal layout (unchanged — output verified byte-identical to the pre-change baseline) or the new_mindmap_vertical: root on top, one column per branch, leaves stacked beneath — deterministic like its horizontal twin (pure function of branch order, RFC-0002 §11-1). The shared_boxhelper is factored out of the closure.Tests
short.inputs:order selects the same graded subset.verticalchanges the SVG bytes and stays deterministic;qbr-c-level(horizontal) stamps and renders as before.Closes #63
🤖 Generated with Claude Code