Repository navigation
Fix weekday-dependent sleep test, timeline NULL-duration 500, binary streak cells - #80
Merged
Merged
Conversation
…streak cells - conftest: cap fixture bedtime before midnight; weekend drift past 24h made test_sleep_lands_on_the_wake_date_not_the_night_it_started fail by run date. - sleep_timeline: NULL sleep_time_seconds no longer crashes int(NaN); duration falls back to the bed->wake span. - behavior_streak_calendar: logged yes/no behaviours (no value) render as 1.0 instead of unlogged. Carried over from the closed #70. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LW7scFTkVq5qopfyQydo4L
dandwhelan
marked this pull request as ready for review
October 3, 2026 07:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/conftest.py): the fixture's weekend bedtime (23.2 + 1.2 h) could tip past midnight, sotest_sleep_lands_on_the_wake_date_not_the_night_it_startedpassed or failed depending on the run date. This is what turned Scale scan: muscle rate, ideal weight, Low/Standard/High ratings #79's CI red. Bedtime is now capped before midnight.sleep_timeline: a row with bed/wake timestamps but a NULLsleep_time_secondsmadeint(NaN)crash/api/visualizations. Duration now falls back to the bed→wake span.behavior_streak_calendar: yes/no behaviours logged with no value had a NaN mean and showed as not logged. They now show as 1.0.Both fixes are carried over from the closed #70 (the rest of #70 is already on main or was superseded). There are two new regression tests: they fail without the fixes and pass with them. Full suite: 706 passed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LW7scFTkVq5qopfyQydo4L
Generated by Claude Code