Add missing error type coverage in domain error type guards#64
Merged
danbim merged 2 commits intoneverthrowfrom Feb 4, 2026
Merged
Add missing error type coverage in domain error type guards#64danbim merged 2 commits intoneverthrowfrom
danbim merged 2 commits intoneverthrowfrom
Conversation
…yParticipantsError Co-authored-by: danbim <300638+danbim@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on refactoring error handling
Add missing error type coverage in domain error type guards
Feb 3, 2026
danbim
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error handling middleware's type guards were incomplete, missing
ScoreTypeMismatchError,ScoreNotFoundError, andTooManyParticipantsErrordespite these errors being returned by domain services.Changes
Type definitions and guards (
src/api/middleware/error-handling.ts):ScoreTypeMismatchErrorandScoreNotFoundErrortoHeatDomainErrorunionTooManyParticipantsErrortoBracketDomainErrorunionisHeatDomainError()to check for both new error typesisBracketDomainError()to check forTooManyParticipantsErrorTest coverage (
__tests__/api/middleware/error-handling.test.ts):ScoreNotFoundErroris recognized byisHeatDomainErrorand maps to 404ScoreTypeMismatchErroris recognized byisHeatDomainErrorand maps to 400TooManyParticipantsErroris recognized byisBracketDomainErrorand maps to 400All error types now have complete type guard coverage and correct HTTP status code mappings.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.