Disable propulsion controls while docking#2723
Open
oznogon wants to merge 6 commits intodaid:masterfrom
Open
Conversation
Apply consistent visibility and update logic patterns across propulsion (impulse, warp, jump) and combat maneuver control wrappers. This prevents inconsistent UI behaviors when adding, removing, and changing their related components at runtime. Also align header guards on use of #pragma once, and remove unnecessary warp_controls and jump_controls pointers from Helms now that visibility logic is consistently handled in the wrapper components.
Add two new helm keybindings: - helms_warp_max: Request maximum warp level, parallel to max impulse and max jump keybinds. Accommodates warp drives with max_level > 4. - helms_set_warp: Set warp request via joystick axis with simulated detents at each warp level.
Remove outdated documentation suggesting warp controls are limited to factor 4.
If a ship has a docking port, disable sliders on warp, impulse, and combat maneuver controls, and the Jump button on jump controls, while docking or docked. Re-enable them when undocked. This reduces the ambiguity of expected behaviors for these controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2720.
If a ship has a docking port, disable sliders on warp, impulse, and combat maneuver controls, and the Jump button on jump controls, while docking or docked. Re-enable them when undocked. This reduces the ambiguity of expected behaviors for these controls.