Repository navigation
[dagster-polars] sink LazyFrame returned inside MaterializeResult - #360
Open
lukew-cogapp wants to merge 1 commit into
Open
lukew-cogapp wants to merge 1 commit into
lukew-cogapp wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An asset that returns
MaterializeResult(value=lazy_frame)has no output annotation fortype_router_is_eagerto read, so it resolves as eager. The LazyFrame goes towrite_df_to_pathand fails withAttributeError: 'LazyFrame' object has no attribute 'write_parquet'.dump_to_pathnow checks the object too, so apl.LazyFramealways goes tosink_df_to_path. Includes a regression test throughPolarsParquetIOManager.