Fix Result[T] status code inconsistency when both Code and Err are set#3
Draft
Copilot wants to merge 5 commits into
Draft
Fix Result[T] status code inconsistency when both Code and Err are set#3Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
Co-authored-by: cymoo <7800791+cymoo@users.noreply.github.com>
Co-authored-by: cymoo <7800791+cymoo@users.noreply.github.com>
Co-authored-by: cymoo <7800791+cymoo@users.noreply.github.com>
Co-authored-by: cymoo <7800791+cymoo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bugs in the framework and add test cases
Fix Result[T] status code inconsistency when both Code and Err are set
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Result[T]has bothCodeandErrfields set, the HTTP status and error JSON body showed different codes:Changes
handleResult: Check for errors before writing status code to prevent double-writehandleErrorWithCode: New function accepts explicit status code alongside errorTest Coverage
Added 7 test cases covering:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.