Repository navigation
Fix flake8-bugbear B045 - #7557
Merged
Merged
Conversation
Loop control variable key overrides a variable in an enclosing loop
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes address B045 without unresolved issues or behavioral changes.
No open issues 🎉
What changed in this PR
This pull request fixes flake8-bugbear B045 warnings by eliminating loop-variable shadowing while preserving existing workflow expansion and family definition behavior.
Changes:
- Renames the inner workflow expansion variable in
id_cli.py. - Simplifies ancestor iteration in
data_store_mgr.pyto avoid reusing enclosing loop variables. - Preserves existing token expansion and data-store behavior.
| File | Description |
|---|---|
cylc/flow/id_cli.py |
Avoids shadowing the outer tokens loop variable during asynchronous workflow expansion. |
cylc/flow/data_store_mgr.py |
Simplifies ancestor iteration to avoid loop-variable shadowing while retaining family definition generation. |
Review effort: Lite
6 tasks done
Member
Author
|
Test failures are unrelated - failure to install is due to #7549 |
ChrisPaulBennett
approved these changes
Oct 28, 2026
ChrisPaulBennett
left a comment
ChrisPaulBennett
left a comment
Contributor
There was a problem hiding this comment.
You beat me to it.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loop control variable key overrides a variable in an enclosing loop
https://github.com/PyCQA/flake8-bugbear/releases/tag/26.10.27
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.