Skip to content

Promote expire triggers from experimental - #7545

Open
Scott-Owen-James wants to merge 7 commits into
cylc:masterfrom
Scott-Owen-James:7175
Open

Scott-Owen-James wants to merge 7 commits into
cylc:masterfrom
Scott-Owen-James:7175

Conversation

@Scott-Owen-James

Copy link
Copy Markdown
Contributor

closes #7175

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@Scott-Owen-James Scott-Owen-James self-assigned this Oct 20, 2026
@Scott-Owen-James

Copy link
Copy Markdown
Contributor Author

Note to self for when you return from holiday:

  • Sort out obsoletion message.
  • Make sure it's in the right place as a config.

@Scott-Owen-James

Scott-Owen-James commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Adding an obsoletion message for suicide triggers in the same manner of other obsoletions in the workflow file is proving to be a shade complicated due to it's format, it doesn't appear to identify the existence of a suicide trigger when it passes it to the upgrader, might be easier to leave the current message method and modify it to announce obsoletion instead.

@Scott-Owen-James
Scott-Owen-James marked this pull request as ready for review October 20, 2026 14:15
@oliver-sanders

Copy link
Copy Markdown
Member

@Scott-Owen-James, the goal was to remove the experimental config and add a u.obsolete line so that continuing to configure it gives a warning.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expire triggers: promote from experimental feature

2 participants