Repository navigation
ci: pin Node.js to 26.12.1 via .node-version - #19
Merged
Merged
Conversation
CI and release ran on `lts/*`. Pin Node.js to 26.12.1, which carries the fix for the leaked eMudhra intermediate CA keys (https://emudhra.we-have-a-problem.com/), and read it from .node-version in both workflows so that bumping it later is a one-line change. mise.toml lets mise read the same .node-version locally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins Node.js to 26.12.1 in CI and release, which ran on
lts/*until now.26.12.1 carries the fix for the leaked eMudhra intermediate CA keys (details): it updates the bundled root certificates to NSS 3.131.1 and rejects chains containing the compromised keys.
.node-version:26.12.1, the single place the version is set.github/workflows/ci.yml,.github/workflows/release.yml:actions/setup-nodereadsnode-version-file: .node-versioninstead oflts/*mise.toml: lets mise read the same.node-versionlocally (mise does not read.node-versionby default)Note that the release job, which publishes to npm with provenance, also moves from
lts/*to 26.12.1. Bumping Node.js later is a one-line change to.node-version.🤖 Generated with Claude Code