Show "Phased" notification when phased, effects fix on quit to char select.#337
Open
skittles1 wants to merge 1 commit intocyberjunk:masterfrom
Open
Show "Phased" notification when phased, effects fix on quit to char select.#337skittles1 wants to merge 1 commit intocyberjunk:masterfrom
skittles1 wants to merge 1 commit intocyberjunk:masterfrom
Conversation
- Show "Phased" rather than "Paralyzed" when phased out. Works by adding a listener on AvatarBuffs and taking action when the phase buff is added and removed. - Phase buff being active prevents "Paralyzed" from being shown. Removing phase does a check for Paralyze being active to handle the hold effect given when phase is cast again. - Clear effects on Reset() in DataController.cs (i.e. when Quit is used). This was previously done in Invalidate() which caused issues removing effects that are not sent again during the server's system save, but Reset() relied on it to reset effects when quitting to char select. Fixes the edge case where quitting to char select while phased would leave the whiteout effect and paralysis when logging back in.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #328.
a listener on AvatarBuffs and taking action when the phase buff is added
and removed.
Removing phase does a check for Paralyze being active to handle the hold
effect given when phase is cast again.
used). This was previously done in Invalidate() which caused issues
removing effects that are not sent again during the server's system
save, but Reset() relied on it to reset effects when quitting to char
select. Fixes the edge case where quitting to char select while phased
would leave the whiteout effect and paralysis when logging back in.