Open
Conversation
…tor even if different separators are set, fixed bug where pressing backspace or delete button on decimals numbers when integer part is > 1000 (and thousand separator != ",") caused the field to reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a502e75 version, if I set a different thousands separator than "," and insert a number > 1000,
then delete a decimal number, the input field is reset.
For example, if I set
decimal separator: , (comma)
thousands separator: . (dot)
and type 1.234,56
If I try to delete the number 5 (both with backspace or delete key), the input field is reset.
This commit fixes this bug.
Moreover, I added the numpad "." as a decimal separator, even if "." is not the decimal separator (credits for this go to ToX82/jquery-number@333e19c)