This repository was archived by the owner on Jul 1, 2025. It is now read-only.
FEAT - Docker Support + Docker Compose file#44
Open
phil-flip wants to merge 8 commits intocurtisf:developmentfrom
Open
FEAT - Docker Support + Docker Compose file#44phil-flip wants to merge 8 commits intocurtisf:developmentfrom
phil-flip wants to merge 8 commits intocurtisf:developmentfrom
Conversation
|
Thanks, I was actually too lazy to do that :D |
Author
|
You're fine. It's just unfortunate, that the owner doesn't seem to merge PRs. |
Owner
|
Could you check out/review the docker-compose.yml in the branch named "selfhost"? That's likely going to be the one that gets distributed for selfhosting in the future. |
Author
|
Everyone has their own taste in Docker-Compose- and Dockerfiles. Personally I don't like it, because it has a lot of extra stuff in it, which is done automatically done by the Docker Compose-Plugin. On the other side, I seem to miss the setup for the DB. The health check is a nice touch tho. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my little implementation of Docker, inspired by #43
Since I changed some var names inside the code, it needs to be retested without Docker and see, if that still works.
The Docker Compose file has been changed in a way to prevent the need for a docker specific .env file. The normal one can be used.
The DB migration is a hotfix at best and should be redone. I wanted to prevent the use of the .dockerenv check as that might cause issues with other platforms like K8s.
If a merge is undesirable that fine. But I also didn't want to keep it to my self. Let me know, if something doesn't work.