feat: exhaustive e2e integration tests and bug fixes - #471
Merged
Conversation
- Fix dual-role access so students promoted to staff can still use student flows - Fix address field font size on party registration form - Add screen reader description to edit party dialog for accessibility - Change "Inactive" active hold filter label to "None" to match column display - Fix student info chip "Completed Party Smart" to only count current school year registrations - Fix column header stale filter value after sort/filter interaction - Fix DatePicker silently snapping to today when invalid text is entered - Add exhaustive e2e test suites: auth flows, police dashboards, staff management, student flows, cross-tab chains, export, forms validation, info chips, invite/dual-role, restrictions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Test Results Summary870 tests +4 870 ✅ +4 1m 13s ⏱️ +8s Results for commit f1e18a6. ± Comparison against base commit a5ee70c. This pull request removes 3 and adds 7 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive integration test coverage across all user roles and flows, and fixes several bugs discovered during the process of writing those tests.
Changes
Bug fixes:
last_registeredcheck to current school year onlyColumnHeaderDatePickersilently snapping to today's date when an invalid/partial date string is entered — now leaves the field as-is until a valid date is parsedE2e tests added:
describeblocks instead of a single flat groupmailpit.helpers.ts,seed-state.helpers.ts,xlsx.helpers.tse2e/README.mddocumenting the test suite structure