feat: key IdP account upsert on PID and remove rate limiter - #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves two related backend cleanups: switching the account uniqueness key used during IdP login to PID, and removing the in-app rate limiter now that a reverse proxy is being introduced.
Changes:
upsert_idp_account) onpidinstead ofonyenwhen looking up an existing account, treating PID as the stable identity and overwritingonyenfrom the IdP payload — consistent with howprovision_staff_accountalready matches staff by PID (onyen -> PID for keying #466)main.py(limiter setup, exception handler, andSlowAPIMiddleware) and drop theslowapidependency frombackend/pyproject.toml, since the new reverse proxy will handle rate limiting (Remove Rate Limiter #467)Closes #466
Closes #467
🤖 Generated with Claude Code