Implements Background Rollback Notary Proofs#368
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref CSF-1105
Note
Medium Risk
Changes the rollback-trade handling path to optionally generate and submit notary proofs, adding new network calls and feature-flagged behavior with a legacy fallback. Risk is moderate due to new API dependencies and potential failure modes around proving/token fetching.
Overview
Rollback handling now supports background notary proofs. When rollback trades are detected,
pingRollbackTradescan (if enabled via/v1/meta/notaryand not Firefox) fetch a notary token, prove relevant trade history viaNotaryProve, and submit the proof to/v1/trades/notaryinstead of sending the legacy rollback ping.If background proving fails, the code reports the error to
/v1/trades/:tradeId/report-errorand falls back to the existingPingRollbackTradeflow. This also centralizes the trade-history fetch limit viaMAX_TRADE_HISTORY_FETCHand wires new bridge handlersFETCH_NOTARY_META/FETCH_NOTARY_TOKENinto the request handler map.Written by Cursor Bugbot for commit a4b267a. This will update automatically on new commits. Configure here.