Repository navigation
chore: prevent most common misconfigurations - #83
Merged
maximilianbraun merged 1 commit intoSep 18, 2025
Merged
maximilianbraun merged 1 commit into
maximilianbraun merged 1 commit into
Conversation
christophrj
force-pushed
the
chore/add-xp-v2-registry-error-handling
branch
5 times, most recently
from
August 20, 2025 17:43
131eb7b to
4341c5f
Compare
Collaborator
Author
christophrj
force-pushed
the
chore/add-xp-v2-registry-error-handling
branch
from
August 25, 2025 09:19
4341c5f to
d5b7b89
Compare
maximilianbraun
approved these changes
Sep 18, 2025
On-behalf-of: @SAP christopher.junk@sap.com Signed-off-by: Christopher Junk <christopher.junk@sap.com>
christophrj
force-pushed
the
chore/add-xp-v2-registry-error-handling
branch
from
September 18, 2025 11:27
d5b7b89 to
5f377dc
Compare
Collaborator
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #80
Added some basic validation checks to fail fast with breaking v2 changes.
This is just for user convenience rather than a necessary change.
This could also be implemented in terms of documentation if you don't want to maintain any additional code.
Or by moving forward to v2 completely in removing the controllerconfig type and registry flag.