fix: move namespace assignment upfront, so it is done for matchLabels+matchName - #628
Closed
fernandezcuesta wants to merge 1 commit into
Closed
fernandezcuesta wants to merge 1 commit into
fernandezcuesta wants to merge 1 commit into
Conversation
…+matchName Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
requested review from
adamwg,
bobh66,
ezgidemirel,
phisco,
sergenyalcin,
turkenf and
ulucinar
as code owners
September 3, 2026 11:26
Contributor
Author
|
Duplicate of #612 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Namespace was silently dropped when using
matchLabelswithExtraResources. Move the namespace assignment up, so we do it before eithermatchLabelsormatchName.Fixes #600
Fixes #597
I have: