feat: add a ZxcvbnPasswordStrength constraint#10
Open
alanpoulain wants to merge 1 commit intocreatenl:masterfrom
Open
feat: add a ZxcvbnPasswordStrength constraint#10alanpoulain wants to merge 1 commit intocreatenl:masterfrom
alanpoulain wants to merge 1 commit intocreatenl:masterfrom
Conversation
alanpoulain
force-pushed
the
feat/validator
branch
from
85b3fbb to
aedc4dc
Compare
alanpoulain
force-pushed
the
feat/validator
branch
from
aedc4dc to
465e886
Compare
Author
|
I've improved the coverage since I think you want to stay at 100%. |
alanpoulain
force-pushed
the
feat/validator
branch
from
465e886 to
f00c9ec
Compare
Author
|
Friendly ping 🙂 |
Member
|
Hi Alan, thanks for your pull request. I opened some discussions a while ago, would you mind taking a look at that? |
Author
|
I don't see the discussions you are talking about. Could you link them? |
AlexLisenkov
reviewed
Jun 8, 2022
| $this->assertNoViolation(); | ||
| } | ||
|
|
||
| public function testEmptyStringIsValid(): void |
Member
There was a problem hiding this comment.
Why did you decide an empty string is valid?
|
|
||
| protected static $errorNames = [self::ZXCVBN_PASSWORD_STRENGTH_ERROR => 'ZXCVBN_PASSWORD_STRENGTH_ERROR']; | ||
|
|
||
| public string $message = 'This password does not have enough strength.{{ warning }}{{ suggestions }}'; |
Member
There was a problem hiding this comment.
Part of this bundle is localization. Is it possible for this string to be localized?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I think it would be nice to have a validator constraint in this bundle too.
The validator is only registered if the user has the
symfony/validatordependency in their project.