Merged
Conversation
Implement comparator to joystick voltages. Fix reversed controls, add CA2 auto-transition when bit 4 is zero. Add ability to set joystick via config file
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
============================================
- Coverage 55.82% 54.01% -1.82%
- Complexity 1022 1029 +7
============================================
Files 71 73 +2
Lines 4650 4843 +193
Branches 542 583 +41
============================================
+ Hits 2596 2616 +20
- Misses 1975 2148 +173
Partials 79 79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings experimental joystick implementation to the emulator. Note that this current implementation uses the JInput library for joystick access and requires certain native DLL or shared object files to be loaded in the host operating system prior to working. This implementation is under development and currently only tested under Ubuntu. Note that no new unit tests were added as this experimental code may be removed in favor of a more robust system such as Lightweight Java Game Library or similar in the future.