Skip to content

feat: improve relationship recall and agent query contracts - #325

Merged
forhappy merged 9 commits into
mainfrom
codex/agent-query-correctness
Sep 21, 2026
Merged

forhappy merged 9 commits into
mainfrom
codex/agent-query-correctness

Conversation

@forhappy

Copy link
Copy Markdown
Contributor

Summary

  • Align callers, impact, and affected with bounded source-backed import/reference postings, alias-shaped module ownership, deterministic provenance, and importer-consistency diagnostics.
  • Add the bounded architecture command, shared output-format parsing, explicit ambiguity/truncation behavior, coverage witnesses, and the 64-candidate default.
  • Make historical reads, exports, and diffs read-only, with actionable prerequisites plus bounded health and state-audit diagnostics.

Verification

  • cargo fmt --all -- --check
  • cargo test -p compass-model --locked
  • cargo test -p compass-query --locked --lib --test code_traversal
  • cargo test -p compass-output -p compass-files -p compass-history --locked --lib
  • cargo test -p compass-graph --locked --lib --test store_snapshot
  • cargo test -p compass-cli --locked --lib --test code_query_cli --test coverage_paths --test help_cli --test history_cli --test install_cli
  • cargo clippy -p compass-model -p compass-query -p compass-output -p compass-files -p compass-cli --lib --locked -- -D warnings
  • sh scripts/check_product_boundary.sh
  • cargo test -p compass-cypher --locked --test tck
  • cargo test -p compass-query --locked --test opencypher_tck
  • python3 scripts/check_compassql_support.py

@forhappy
forhappy merged commit 3fd246d into main Sep 21, 2026
14 checks passed
GQAdonis added a commit to GQAdonis/compass that referenced this pull request Sep 22, 2026
Absorb ten upstream commits (PR crabbuild#325): source-backed alias/import/export
usage evidence in callers/impact/affected, live CompassQL node degree,
historical reads that neutralize checkout filters, the bounded
`compass architecture` view, and the shared agent output formats.

Conflict resolution kept both sides wherever they were disjoint:

- compass-model/src/search.rs: our `searchable_node_terms`, which the
  Surreal projection depends on, alongside upstream's new
  `RELATIONSHIP_SEARCH_EDGE_KINDS`. Neither side had the other's symbol.
- compass-cli/src/install_commands.rs: our focused-skill collection
  preflight and consumer updates beside upstream's managed-skill probe
  and state-event journaling. All eight functions have live call sites.
- compass-cli/src/help.rs: upstream's newer option text in all seven
  hunks, with our `--engine ...|surreal` option re-applied to each.

One resolution takes upstream over this fork's version. Our
`RELATIONSHIP_TERM_INDEX_CAPABILITY_V2` guarded postings that are
byte-identical to the ones `_V1` guards: `af0bb1d0` added `_V2` without
removing `_V1`, `direct_call_source_identifier_postings` is unchanged
from the merge base, and the base already stored the `(source, term,
target)` evidence that commit claimed as new. Keeping `_V2` would make
this fork report incomplete relationship coverage for every
upstream-written snapshot — a false negative on complete, immutable
data — so the marker returns to `_V1` and the three remaining
references follow it. No migration is required: snapshots from any
0.3.x-lineage builder stay mutually readable. The now-false v2 claims
in CHANGELOG.md and COMPATIBILITY.md are corrected.

Re-pin the canonical skill digest; upstream documented its new
`architecture` command in SKILL.md, which the build-time guard rejects
until the digest is refreshed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@forhappy forhappy mentioned this pull request Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant