-
Notifications
You must be signed in to change notification settings - Fork 14
Add Code Rabbit AI config #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Code Rabbit AI config #156
Conversation
📝 WalkthroughWalkthroughA new configuration file Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.coderabbit.yaml:
- Around line 48-58: Reword the documentation guidance under the
"**/*.{cpp,hpp}" instructions to improve clarity: change "which gives a high
level overview of how the implementation works." to "Provide a high-level
overview of the implementation."; tighten the next sentence to "Use single-line
// comments sparingly to explain the why (not the what or how) when it is
non-obvious." and clarify the final sentence to "Docstrings are required for all
classes in public headers within non-detail namespaces; warn when a class or
function lacks a docstring or has an insufficient one." Ensure these phrases
replace the current lines in the instructions block so the intent and grammar
are clearer.
| - path: "**/*.{cpp,hpp}" | ||
| instructions: | | ||
| Documentation Best Practices | ||
| - The top of the file after the includes, put a nice /* */ section | ||
| which gives a high level overview of how the implementation works. | ||
| - Single line // comments are to be used sparingly and judiciously | ||
| which explain the why (not the what or how) when it is non-obvious. | ||
| - Docstrings are required for all classes in public headers in | ||
| non detail namespaces. They are used for generating the Documentation | ||
| website. Please give warnings for any class or function that does | ||
| not have a docstring or has an insufficient docstring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor grammatical improvement in instructions.
Line 51 has awkward phrasing that could be clarified for better readability.
Suggested fix
path_instructions:
- path: "**/*.{cpp,hpp}"
instructions: |
Documentation Best Practices
- - The top of the file after the includes, put a nice /* */ section
+ - At the top of the file after the includes, put a nice /* */ section
which gives a high level overview of how the implementation works.
- Single line // comments are to be used sparingly and judiciously
which explain the why (not the what or how) when it is non-obvious.
- Docstrings are required for all classes in public headers in
non detail namespaces. They are used for generating the Documentation
website. Please give warnings for any class or function that does
not have a docstring or has an insufficient docstring.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - path: "**/*.{cpp,hpp}" | |
| instructions: | | |
| Documentation Best Practices | |
| - The top of the file after the includes, put a nice /* */ section | |
| which gives a high level overview of how the implementation works. | |
| - Single line // comments are to be used sparingly and judiciously | |
| which explain the why (not the what or how) when it is non-obvious. | |
| - Docstrings are required for all classes in public headers in | |
| non detail namespaces. They are used for generating the Documentation | |
| website. Please give warnings for any class or function that does | |
| not have a docstring or has an insufficient docstring. | |
| - path: "**/*.{cpp,hpp}" | |
| instructions: | | |
| Documentation Best Practices | |
| - At the top of the file after the includes, put a nice /* */ section | |
| which gives a high level overview of how the implementation works. | |
| - Single line // comments are to be used sparingly and judiciously | |
| which explain the why (not the what or how) when it is non-obvious. | |
| - Docstrings are required for all classes in public headers in | |
| non detail namespaces. They are used for generating the Documentation | |
| website. Please give warnings for any class or function that does | |
| not have a docstring or has an insufficient docstring. |
🤖 Prompt for AI Agents
In @.coderabbit.yaml around lines 48 - 58, Reword the documentation guidance
under the "**/*.{cpp,hpp}" instructions to improve clarity: change "which gives
a high level overview of how the implementation works." to "Provide a high-level
overview of the implementation."; tighten the next sentence to "Use single-line
// comments sparingly to explain the why (not the what or how) when it is
non-obvious." and clarify the final sentence to "Docstrings are required for all
classes in public headers within non-detail namespaces; warn when a class or
function lacks a docstring or has an insufficient one." Ensure these phrases
replace the current lines in the instructions block so the intent and grammar
are clearer.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.