Skip to content

Don't notify solvers about failed solutions with a haircut fee#4115

Merged
squadgazzz merged 3 commits intomainfrom
no-failed-haircut-notification
Feb 5, 2026
Merged

Don't notify solvers about failed solutions with a haircut fee#4115
squadgazzz merged 3 commits intomainfrom
no-failed-haircut-notification

Conversation

@squadgazzz
Copy link
Contributor

Description

This PR addresses a comment that suggests avoiding notifying solvers on failed solutions encoding that were configured with a haircut fee. Also, updates the metric to easily identify the error rate of solutions with the haircut fee to configure a new alert to take any action.

@squadgazzz squadgazzz requested a review from a team as a code owner February 3, 2026 09:02
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The changes suppress notifications for failed solutions with a haircut fee and update metrics accordingly. The implementation correctly reflects the PR's objectives. No critical issues found.

Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super small nit

Copy link
Member

@AryanGodara AryanGodara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

@squadgazzz squadgazzz added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 86fe6a0 Feb 5, 2026
19 checks passed
@squadgazzz squadgazzz deleted the no-failed-haircut-notification branch February 5, 2026 14:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants